osmo-ttcn3-hacks[master]: Move make artifacts to build subdir

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Fri Mar 23 19:58:56 UTC 2018


Patch Set 4: Code-Review-1

(5 comments)

I wish I had thought of this before I started with the .gitignore patches. I approve, just some details up for nitpick:

https://gerrit.osmocom.org/#/c/7405/4/bsc/regen_makefile.sh
File bsc/regen_makefile.sh:

Line 14: ln -s build/BSC_Tests ../BSC_Tests || true
My first reflex is to not want this around.
It is useful to be able to run older versions of osmo-ttcn3-hacks in the same docker-playground.
Maybe rather docker-playground can look for the binary in both places and use a build/* one if it exists?

(If we get rid of these links, we can also drop another .gitignore rule)


https://gerrit.osmocom.org/#/c/7405/4/gen_links.sh.inc
File gen_links.sh.inc:

Line 4: rm -f .gitignore
-1: drop (s.b.)


Line 11: 	echo "$f" >> .gitignore
-1: All .gitignore related stuff is now no longer needed, remove this. It was there to ignore exactly those files that were symlinked, now we can just ignore the entire build/ dir instead.


Line 17: 	DSTDIR=$1
-0: it's always "./build/", isn't it? The patch would be a lot smaller if we just did "./build/$f" below. You could even define a DSTDIR="./build" default above, and the including script could override that, if it would ever be necessary.


https://gerrit.osmocom.org/#/c/7405/4/sgsn/regen_makefile.sh
File sgsn/regen_makefile.sh:

Line 14: ln -s build/SGSN_Tests ../SGSN_Tests || true
> We are in $BASE/sgsn/build directory, because we do "cd build" in line 3 in
Yes, it's correct, but I still think it would be nice to have only one place for the binary and outsource the "build/" path element to docker-playground.


-- 
To view, visit https://gerrit.osmocom.org/7405
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9ca176869ce6b80ccf2b2fff6554b121e1aa85c
Gerrit-PatchSet: 4
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list