osmo-sip-connector[master]: comments

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Fri Mar 23 19:24:12 UTC 2018


Patch Set 1: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/#/c/7489/1/src/mncc.c
File src/mncc.c:

Line 150: /* Send a MNCC_RTP_CONNET to the MSC for the given call legs */
"CONNECT"


Line 463:  *  \param conn MNCC socket/connection
(I don't mind much, but at some point I think we argued for 'param[in,out]' or 'param[inout]'?)


-- 
To view, visit https://gerrit.osmocom.org/7489
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf0e9211a4e93eb1b05b5a5d68f9ba766982da8d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list