This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgReview at https://gerrit.osmocom.org/7458 gsm_08_08: correct speech codec defaults The speech codec defaults are not correct. The defaults recommended in 3GPP TS 28.062, Table 7.11.3.1.3-2 are limited by 3GPP TS 48.008, Section 3.2.2.103. Some defaults are actually reserved for future use. Also the endianess of the 16 bit values is reversed. - correct values so that they match the specification - revert endianess for a correct transmission Change-Id: I6c3a34d39a375d71c4128fd38f06629e8b98b100 --- M include/osmocom/gsm/protocol/gsm_08_08.h 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/58/7458/1 diff --git a/include/osmocom/gsm/protocol/gsm_08_08.h b/include/osmocom/gsm/protocol/gsm_08_08.h index 947f90f..8276477 100644 --- a/include/osmocom/gsm/protocol/gsm_08_08.h +++ b/include/osmocom/gsm/protocol/gsm_08_08.h @@ -460,16 +460,16 @@ * configuration that is used on the air interface (Um). * * Default values for FR_AMR, HR_AMR and OHR_AMR: - * See also: 3GPP TS 28.062, Table 7.11.3.1.3-2: Preferred - * Configurations for the Adaptive Multi-Rate Codec Types + * See also: 3GPP TS 28.062, Table 7.11.3.1.3-2: Preferred Configurations for + * the Adaptive Multi-Rate Codec Types and 3GPP TS 48.008, Section 3.2.2.103. * * Default values for FR_AMR_WB, OFR_AMR_WB and OHR_AMR_WB: * See also: 3GPP TS 26.103, Table 5.7-1: Allowed Configurations * for the Adaptive Multi-Rate - Wideband Codec Types */ enum gsm0808_speech_codec_defaults { - GSM0808_SC_CFG_DEFAULT_FR_AMR = 0xffff, - GSM0808_SC_CFG_DEFAULT_HR_AMR = 0x073f, - GSM0808_SC_CFG_DEFAULT_OHR_AMR = 0xffff, + GSM0808_SC_CFG_DEFAULT_FR_AMR = 0xff57, + GSM0808_SC_CFG_DEFAULT_HR_AMR = 0x3f07, + GSM0808_SC_CFG_DEFAULT_OHR_AMR = 0xff57, GSM0808_SC_CFG_DEFAULT_FR_AMR_WB = 0x01, GSM0808_SC_CFG_DEFAULT_OFR_AMR_WB = 0x3f, GSM0808_SC_CFG_DEFAULT_OHR_AMR_WB = 0x01, -- To view, visit https://gerrit.osmocom.org/7458 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6c3a34d39a375d71c4128fd38f06629e8b98b100 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: dexter <pmaier at sysmocom.de>