osmo-ttcn3-hacks[master]: Move make artifacts to build subdir

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Mar 22 15:11:28 UTC 2018


Patch Set 4: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/7405/4/sgsn/regen_makefile.sh
File sgsn/regen_makefile.sh:

Line 14: ln -s build/SGSN_Tests ../SGSN_Tests || true
did you actually test this with docker-playground?  I think you got the hierarchy wrong.  If we are in the "sgsn" subdirectory, then build/SGSN_Tests is correct, but ../ would create the link in osmo-ttcn3-hacks/

If we are in the sgsn/build directory, and we use this command, then we create a link from sgsn/build/build/SGSN_Tests to sgsn/SGSN_Tests and build/build doesn't exist.

Please confirm if I'm reading this wrong and if you successfully tested with docker-playground.  If not, merging this test would likely break all automatic tests.


-- 
To view, visit https://gerrit.osmocom.org/7405
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9ca176869ce6b80ccf2b2fff6554b121e1aa85c
Gerrit-PatchSet: 4
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list