openbsc[master]: libmsc/auth.c: use libosmogsm authentication API

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Mar 22 05:14:18 UTC 2018


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/7398/2/openbsc/src/libmsc/auth.c
File openbsc/src/libmsc/auth.c:

Line 107: 		aud2g.algo = OSMO_AUTH_ALG_XOR;
IIUC, there is no actual XOR implementation as osmo_auth_algo in libosmocore; there's lots of stubs, but no actual registering of an osmo_auth_algo: grep for "MILENAGE" shows 

  auth_milenage.c:172:	.algo = OSMO_AUTH_ALG_MILENAGE,

but no such match for XOR.


-- 
To view, visit https://gerrit.osmocom.org/7398
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08dae631bcfc1bb3a4817084723e04a59c745329
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list