This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.orgPatch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/7410/1/src/target/trx_toolkit/burst_gen.py File src/target/trx_toolkit/burst_gen.py: Line 74: self.data_if = DATAInterface(self.remote_addr, self.base_port + 2, Let's please avoid lots of tabs... Despite the '80 chars line limitation' was abandoned, I am personally still would prefer to follow it anyway. My screen resolution doesn't allow me to see anything after 'self.bind_addr ...'. My suggestion is: DATAInterface(remote_addr, remote_port, (\t)bind_addr, bind_port) Line 166: print(s % (self.remote_addr, self.bind_ip, self.base_port)) There is no 'self.bind_ip', should be 'self.bind_addr'. -- To view, visit https://gerrit.osmocom.org/7410 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7be18fef40967fb7551f4115f22cbbd9cdb0840d Gerrit-PatchSet: 1 Gerrit-Project: osmocom-bb Gerrit-Branch: fixeria/trx Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-HasComments: Yes