[MERGED] osmo-ttcn3-hacks[master]: start-testsuite.sh: Use shellcheck to harden script

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun Mar 18 16:08:21 UTC 2018


Harald Welte has submitted this change and it was merged.

Change subject: start-testsuite.sh: Use shellcheck to harden script
......................................................................


start-testsuite.sh: Use shellcheck to harden script

Change-Id: Iaf887da7ad95ba8b1fe93fe6c29f0518961d2fbb
---
M start-testsuite.sh
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/start-testsuite.sh b/start-testsuite.sh
index 83c381e..61bf771 100755
--- a/start-testsuite.sh
+++ b/start-testsuite.sh
@@ -10,7 +10,7 @@
 fi
 
 SUITE=$1
-CFG=`basename $SUITE`.cfg
+CFG=$(basename "$SUITE").cfg
 if [ $# -gt 1 ]; then
 	CFG=$2
 fi
@@ -19,4 +19,4 @@
 	TEST=$3
 fi
 
-LD_LIBRARY_PATH=`dirname $SUITE`:/usr/lib/titan:/usr/ttcn3/lib ttcn3_start $SUITE $CFG $TEST
+LD_LIBRARY_PATH=$(dirname "$SUITE"):/usr/lib/titan:/usr/ttcn3/lib ttcn3_start "$SUITE" "$CFG" "$TEST"

-- 
To view, visit https://gerrit.osmocom.org/7369
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf887da7ad95ba8b1fe93fe6c29f0518961d2fbb
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list