[MERGED] osmo-bsc[master]: abisip-find: Improve use information output

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Mar 16 18:54:45 UTC 2018


Harald Welte has submitted this change and it was merged.

Change subject: abisip-find: Improve use information output
......................................................................


abisip-find: Improve use information output

Interestingly, SO_BINDTODEVICE used to bind to a specific iface
requires root permissions. However, the same target can be accomplished
by binding to a local IP addr set on the target interface, which doesn't
require root permissions in this case.

Change-Id: Ie123c45005d68b186cb06538f7bd31f3b2513007
---
M src/ipaccess/abisip-find.c
1 file changed, 5 insertions(+), 3 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/ipaccess/abisip-find.c b/src/ipaccess/abisip-find.c
index 03f579b..21ed50e 100644
--- a/src/ipaccess/abisip-find.c
+++ b/src/ipaccess/abisip-find.c
@@ -436,9 +436,11 @@
 
 	handle_options(argc, argv);
 
-	if (!cmdline_opts.ifname)
-		fprintf(stdout, "- You might need to specify the outgoing\n"
-			"  network interface, e.g. ``%s eth0''\n", argv[0]);
+	if (!cmdline_opts.ifname && !cmdline_opts.bind_ip)
+		fprintf(stdout, "- You might need to specify the outgoing network interface,\n"
+			"  e.g. ``%s eth0'' (requires root permissions),\n"
+			"  or alternatively use -b to bind to the source address\n"
+			"  assigned to that interface\n", argv[0]);
 	if (!cmdline_opts.list_view)
 		fprintf(stdout, "- You may find the --list-view option convenient.\n");
 	else if (cmdline_opts.send_interval >= cmdline_opts.list_view_timeout)

-- 
To view, visit https://gerrit.osmocom.org/7323
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie123c45005d68b186cb06538f7bd31f3b2513007
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list