[MERGED] osmo-gsm-tester[master]: bts_osmo.py: ready_for_pcu is of public access from tests, m...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu Mar 15 23:57:20 UTC 2018


Pau Espin Pedrol has submitted this change and it was merged.

Change subject: bts_osmo.py: ready_for_pcu is of public access from tests, move it accordingly
......................................................................


bts_osmo.py: ready_for_pcu is of public access from tests, move it accordingly

Change-Id: Ie8978854404897ae5de7e3100d55d86c7a5c1df1
---
M src/osmo_gsm_tester/bts_osmo.py
1 file changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved
  Harald Welte: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/osmo_gsm_tester/bts_osmo.py b/src/osmo_gsm_tester/bts_osmo.py
index f4210b8..5ae3392 100644
--- a/src/osmo_gsm_tester/bts_osmo.py
+++ b/src/osmo_gsm_tester/bts_osmo.py
@@ -65,11 +65,6 @@
     def remote_addr(self):
         return self.conf.get('addr')
 
-    def ready_for_pcu(self):
-        if not self.proc_bts or not self.proc_bts.is_running:
-            return False
-        return 'BTS is up' in (self.proc_bts.get_stderr() or '')
-
     def cleanup(self):
         'Nothing to do by default. Subclass can override if required.'
         pass
@@ -82,6 +77,11 @@
         'Starts BTS proccess and sets self.proc_bts with an object of Process interface'
         pass
 
+    def ready_for_pcu(self):
+        if not self.proc_bts or not self.proc_bts.is_running:
+            return False
+        return 'BTS is up' in (self.proc_bts.get_stderr() or '')
+
     def pcu(self):
         if self._pcu is None:
             self._pcu = self.create_pcu()

-- 
To view, visit https://gerrit.osmocom.org/7159
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie8978854404897ae5de7e3100d55d86c7a5c1df1
Gerrit-PatchSet: 5
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>



More information about the gerrit-log mailing list