This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.orgPatch Set 1: Verified-1 (5 comments) And in general, do we have any expected values, that could be used to make basic test coverage? https://gerrit.osmocom.org/#/c/7310/1/src/gsm/auth_xor.c File src/gsm/auth_xor.c: Line 52: if (aud->type == OSMO_AUTH_TYPE_GSM) I've manually added this, because the previous code was always using the 'aud->u.umts.k'. Line 85: vec->sres[i] ^= vec->res[i + 8] ^ vec->res[i + 12]; This part was missing in the original patch, but is defined in the specification. Line 97: /* The further part is UMTS specific */ Also added manually, correct if this is wrong. Line 113: memcpy(cdout, (uint8_t *) &aud->u.umts.sqn, 6); The actual value is stored in the right part of the buffer, but we take bytes from the left... Should we shift it somehow? Or just move the pointer? Line 129: xor(vec->autn, (uint8_t *) &aud->u.umts.sqn, ak, sizeof(ak)); Same question here... -- To view, visit https://gerrit.osmocom.org/7310 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1afaf0a9e2dce43aec87964bacefb21ed4d3d565 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-HasComments: Yes