[MERGED] openbsc[master]: bts chan_load: ignore unusable BTS

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Mar 14 21:00:43 UTC 2018


Harald Welte has submitted this change and it was merged.

Change subject: bts chan_load: ignore unusable BTS
......................................................................


bts chan_load: ignore unusable BTS

For unconnected BTS, the channel load would report a "bogus channel load
sample" every second (on RLL debug). Instead, skip unusable BTS.

This follows up on commit 6cee893a0f2c4e53155a2631aff12a5f615b973d /
I57e38f6d6ba3b23cc6e1f9520b90261dbb1f1cec
'Make "waiting indicator" of IMMEDIATE ASSIGN REJECT dynamic.'

Port of omo-bsc commit f802f7fd7aec1d91084231a80bbce6f2ed7bd299

Change-Id: Icd50d101244641a6ffdde17e60d7a89719225c65
---
M openbsc/src/libbsc/chan_alloc.c
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/openbsc/src/libbsc/chan_alloc.c b/openbsc/src/libbsc/chan_alloc.c
index cf6b708..2fd197f 100644
--- a/openbsc/src/libbsc/chan_alloc.c
+++ b/openbsc/src/libbsc/chan_alloc.c
@@ -554,6 +554,11 @@
 	static const uint8_t max_wait_ind = 128; /* max wait ~2 minutes */
 	int i;
 
+	/* Ignore BTS that are not in operation, in order to not flood the log with "bogus channel load"
+	 * messages */
+	if (!trx_is_usable(bts->c0))
+		return;
+
 	/* Sum up current load across all channels. */
 	memset(&pl, 0, sizeof(pl));
 	bts_chan_load(&pl, bts);

-- 
To view, visit https://gerrit.osmocom.org/7293
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icd50d101244641a6ffdde17e60d7a89719225c65
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list