osmo-gsm-tester[master]: Create Pcu abstract class and make OsmoPcu inherit from it

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Wed Mar 14 10:26:05 UTC 2018


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/7158/3/src/osmo_gsm_tester/pcu.py
File src/osmo_gsm_tester/pcu.py:

Line 30: ##############
> don't see why this comment. I'm allowed to instantiate a Pcu class and use 
You cannot do it because this is an abstract class (as specified byinheriting from metaclass=ABCMeta, so you are not expected to use it publically (as it instantiating a Pcu class directly). Only subclasses can call it, that's why it's in the protected section.

I'll add doc to it.


-- 
To view, visit https://gerrit.osmocom.org/7158
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3fd4551d1f2932362f99f7d44d65f8ae4fd1979
Gerrit-PatchSet: 3
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list