This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Patch Set 4:
(5 comments)
https://gerrit.osmocom.org/#/c/7168/4/src/osmo_gsm_tester/bts_nanobts.py
File src/osmo_gsm_tester/bts_nanobts.py:
Line 36: if conf.get('addr', None) is None:
> conf.get('addr') is identical to passing None explicitly
AFAIR if you don't pass a second argument, then it throws an exception if the element is not found.
Line 105: ipfind = AbisIpFind(self.suite_run, self.run_dir, iface, 'preconf')
> (do we also do this for sysmoBTS? So far we just assume the BTS is there, r
The Sysmobts is always on since we control the osmo-bts inside it directly. For the nanobts we cannot do it, which means it will try to connect to the BSC all the time, that's why we decide to control it with a smart power socket.
Line 121: # BTS restarting.
> but abis-ip find was already up there.
It was restarted by ipconfig.set_oml_ip(self.bsc.addr(), True).
The true is restart=True. It seems nanobts must be restarted after being reconfigured.
Line 131: event_loop.wait(self, self.bsc.bts_is_connected, self, timeout=600)
> would this technically be enough without the sleep and second abisip find?
Yes, but I prefer having the second AbisIpFind to have more control and be able to spot easily if there's an issue after restarting the nanoBTS, or if it's an issue only in osmo-bsc.
Line 156: class AbisIpFind(log.Origin):
> could be useful for other bts, e.g. the nano3G also responds to abisip-find
We can discuss nano3g required steps and see what will be eactly needed.
--
To view, visit https://gerrit.osmocom.org/7168
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibaea025b3a503dfe897d36701234445de6d49f82
Gerrit-PatchSet: 4
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes