osmo-gsm-tester[master]: Create Pcu abstract class and make OsmoPcu inherit from it

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Mar 13 20:41:08 UTC 2018


Patch Set 3: Code-Review+1

(1 comment)

same cosmetic difference in opinion...

https://gerrit.osmocom.org/#/c/7158/3/src/osmo_gsm_tester/pcu.py
File src/osmo_gsm_tester/pcu.py:

Line 30: ##############
don't see why this comment. I'm allowed to instantiate a Pcu class and use it as I might, am I not? There are no implications, it's not a singleton. The fact that __init__ is usually not called directly is already indicated by the double underscores, and it's intrinsic to python == everyone knows it. What do you mean by "protected" here? (and if there is a point, --> doc string)


-- 
To view, visit https://gerrit.osmocom.org/7158
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3fd4551d1f2932362f99f7d44d65f8ae4fd1979
Gerrit-PatchSet: 3
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list