This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Stefan Sperling gerrit-no-reply at lists.osmocom.orgReview at https://gerrit.osmocom.org/7268 restore sending of optional MM info messages Since commit 2483f1b050496eda7f8707327204251c57212906 the function gsm48_tx_mm_info() was not called anymore. No MM info messages were transmitted to phones even if MM info messages were enabled via VTY. With this commit, we call gsm48_tx_mm_info() after sending an AUTHENTICATION REQUEST, as recommended in TS 100 940 V7.8.0, section 4.3.6 "MM information procedure". Change-Id: Icc413956595588e0832dad2d758de1db8dd5529d Related: OS#2850 --- M src/libmsc/gsm_04_08.c 1 file changed, 17 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/68/7268/1 diff --git a/src/libmsc/gsm_04_08.c b/src/libmsc/gsm_04_08.c index 08f1517..7551b55 100644 --- a/src/libmsc/gsm_04_08.c +++ b/src/libmsc/gsm_04_08.c @@ -3529,9 +3529,23 @@ bool send_autn) { struct gsm_subscriber_connection *conn = msc_conn_ref; - return gsm48_tx_mm_auth_req(conn, at->vec.rand, - send_autn? at->vec.autn : NULL, - at->key_seq); + int rc; + + rc = gsm48_tx_mm_auth_req(conn, at->vec.rand, send_autn? at->vec.autn : NULL, at->key_seq); + + /* ETSI TS 100 940 V7.8.0 (2000-10), 4.3.6 MM information procedure, says: + * "The network may be able to select particular instants where it can send the MM INFORMATION + * message without adding delay to, or interrupting, any CM layer transaction, e.g. immediately + * after the AUTHENTICATION REQUEST message." */ + if (rc == 0 && conn->network->send_mm_info) { + rc = gsm48_tx_mm_info(conn); + if (rc != 0) { + LOGP(DMM, LOGL_NOTICE, "Could not send MM info\n"); + rc = 0; + } + } + + return rc; } /* VLR asks us to send an authentication reject */ -- To view, visit https://gerrit.osmocom.org/7268 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icc413956595588e0832dad2d758de1db8dd5529d Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>