libosmocore[master]: support for more cell ID list types in libosmocore

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Stefan Sperling gerrit-no-reply at lists.osmocom.org
Mon Mar 12 17:44:43 UTC 2018


Patch Set 14:

(2 comments)

https://gerrit.osmocom.org/#/c/6509/14/include/osmocom/gsm/gsm0808.h
File include/osmocom/gsm/gsm0808.h:

Line 33: struct gsm0808_cell_id_list;
> this structs is defined in above protocol/gsm_08_08.h so no real point in a
Yep, will do in next patch set.


https://gerrit.osmocom.org/#/c/6509/14/include/osmocom/gsm/gsm0808_utils.h
File include/osmocom/gsm/gsm0808_utils.h:

Line 35: struct gsm0808_cell_id_list2 {
> why don't you define it next to gsm0808_cell_id_list in protocol/gsm_08_08.
Because this is not a protocol-layer structure.
It is a parsed representation, not a network packet format.


-- 
To view, visit https://gerrit.osmocom.org/6509
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7e754f538df0c83298a3c958b4e15a32fcb8abb
Gerrit-PatchSet: 14
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list