[PATCH] osmo-ttcn3-hacks[master]: L1CTL: Try FBSB up to 10 times in f_L1CTL_FBSB()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Mar 12 14:07:39 UTC 2018


Review at  https://gerrit.osmocom.org/7232

L1CTL: Try FBSB up to 10 times in f_L1CTL_FBSB()

For some reason, even with a perfectly valid/strong signal, the FBSB
task sometimes fails in the firmware.  Let's wrap a loop around
it and try up to 10 times before failing the test.

Change-Id: I2262278dcd7e2f0cf4d293e0549527866522bece
---
M library/L1CTL_PortType.ttcn
1 file changed, 8 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/32/7232/1

diff --git a/library/L1CTL_PortType.ttcn b/library/L1CTL_PortType.ttcn
index 30f4f70..2feff88 100644
--- a/library/L1CTL_PortType.ttcn
+++ b/library/L1CTL_PortType.ttcn
@@ -35,15 +35,18 @@
 
 	function f_L1CTL_FBSB(L1CTL_PT pt, Arfcn arfcn, L1ctlCcchMode ccch_mode := CCCH_MODE_COMBINED) {
 		timer T := 5.0;
-		pt.send(t_L1CTL_FBSB_REQ(arfcn, t_L1CTL_FBSB_F_ALL, 0, ccch_mode, 0));
-		T.start
-		alt {
-			[] pt.receive(t_L1CTL_FBSB_CONF(0)) {};
-			[] pt.receive(t_L1CTL_FBSB_CONF(?)) {
+		for (var integer i := 0; i < 10; i := i+1) {
+			pt.send(t_L1CTL_FBSB_REQ(arfcn, t_L1CTL_FBSB_F_ALL, 0, ccch_mode, 63));
+			T.start
+			alt {
+			[] pt.receive(t_L1CTL_FBSB_CONF(0)) { return; };
+			[] pt.receive(t_L1CTL_FBSB_CONF(?)) { }
+			[i == 9] pt.receive(t_L1CTL_FBSB_CONF(?)) {
 				setverdict(fail, "FBSB Failed with non-zero return code");
 				};
 			[] pt.receive { repeat; };
 			[] T.timeout { setverdict(fail, "Timeout in FBSB") };
+			}
 		}
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/7232
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2262278dcd7e2f0cf4d293e0549527866522bece
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>



More information about the gerrit-log mailing list