[MERGED] osmocom-bb[fixeria/trx]: trxcon: use meaningful names for L1CTL messages

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun Mar 11 10:05:49 UTC 2018


Harald Welte has submitted this change and it was merged.

Change subject: trxcon: use meaningful names for L1CTL messages
......................................................................


trxcon: use meaningful names for L1CTL messages

There are two types of L1CTL messages: received and to be
transmitted. Let's use proper names to indicate this.

Change-Id: I7c17687579282fa389bca35dc7edbc3582e55701
---
M src/host/trxcon/l1ctl.c
M src/host/trxcon/l1ctl_link.c
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/host/trxcon/l1ctl.c b/src/host/trxcon/l1ctl.c
index dd75af9..58b8a4f 100644
--- a/src/host/trxcon/l1ctl.c
+++ b/src/host/trxcon/l1ctl.c
@@ -49,7 +49,7 @@
 static struct msgb *l1ctl_alloc_msg(uint8_t msg_type)
 {
 	struct l1ctl_hdr *l1h;
-	struct msgb *msg = msgb_alloc_headroom(256, 4, "osmo_l1");
+	struct msgb *msg = msgb_alloc_headroom(256, 4, "l1ctl_tx_msg");
 
 	if (!msg) {
 		LOGP(DL1C, LOGL_ERROR, "Failed to allocate memory\n");
diff --git a/src/host/trxcon/l1ctl_link.c b/src/host/trxcon/l1ctl_link.c
index 596a9d1..a7277ea 100644
--- a/src/host/trxcon/l1ctl_link.c
+++ b/src/host/trxcon/l1ctl_link.c
@@ -77,7 +77,7 @@
 
 	/* Allocate a new msg */
 	msg = msgb_alloc_headroom(L1CTL_LENGTH + L1CTL_HEADROOM,
-		L1CTL_HEADROOM, "L1CTL");
+		L1CTL_HEADROOM, "l1ctl_rx_msg");
 	if (!msg) {
 		LOGP(DL1D, LOGL_ERROR, "Failed to allocate msg\n");
 		return -ENOMEM;

-- 
To view, visit https://gerrit.osmocom.org/7207
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7c17687579282fa389bca35dc7edbc3582e55701
Gerrit-PatchSet: 2
Gerrit-Project: osmocom-bb
Gerrit-Branch: fixeria/trx
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list