[MERGED] libtelnet[master]: Fix no-return-in-nonvoid-function ipaccess-auth.c:80

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Mar 8 20:44:28 UTC 2018


Harald Welte has submitted this change and it was merged.

Change subject: Fix no-return-in-nonvoid-function ipaccess-auth.c:80
......................................................................


Fix no-return-in-nonvoid-function ipaccess-auth.c:80

OBS post-build check complained:

Change-Id: Id1368f308f0af6ac88334002a8aa1e90737e563b
I: Program returns random data in a function
E: libtelnet no-return-in-nonvoid-function ipaccess-auth.c:80
---
M util/ipaccess-auth.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved; Verified



diff --git a/util/ipaccess-auth.c b/util/ipaccess-auth.c
index e550f4a..e290acb 100644
--- a/util/ipaccess-auth.c
+++ b/util/ipaccess-auth.c
@@ -30,7 +30,7 @@
 }
 
 // nanoBTS Challenge/Response
-int ipaccess_telnet_auth(int sock)
+void ipaccess_telnet_auth(int sock)
 {
 	char buffer[512];
 	int rs;

-- 
To view, visit https://gerrit.osmocom.org/7157
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id1368f308f0af6ac88334002a8aa1e90737e563b
Gerrit-PatchSet: 1
Gerrit-Project: libtelnet
Gerrit-Branch: master
Gerrit-Owner: roox <mardnh at gmx.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>



More information about the gerrit-log mailing list