This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPatch Set 6: Code-Review+2 (2 comments) https://gerrit.osmocom.org/#/c/6918/6/src/osmo_ms_driver/location_update_test.py File src/osmo_ms_driver/location_update_test.py: Line 115: ms.start(loop) Oh I now see what you were saying about the variables. This should be better called phy instead of ms. Can be fixed later if it's easier for you. Line 118: for ms in self._phys: Same here, it should be named phy instead of ms, and of course then ms.verify_phy_ready() can already be called phy.verify_ready(). Again, can be fixed later if t's a lot of hassle to change it now. -- To view, visit https://gerrit.osmocom.org/6918 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3277ed0f0f9ee734569bedd4752564eb68c9cfd Gerrit-PatchSet: 6 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes