This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Patch Set 1:
(5 comments)
minor cosmetics...
https://gerrit.osmocom.org/#/c/7127/1/ansible/roles/gsm-tester-modems/tasks/main.yml
File ansible/roles/gsm-tester-modems/tasks/main.yml:
Line 2: # modems
USRP and UHD are not related to modems, it is about SDR based BTSes: the entire UHD stuff should not be under gsm-tester-modems/
Line 25: - name: install gobi2000 packages
ws
https://gerrit.osmocom.org/#/c/7127/1/ansible/roles/gsm-tester-network/README.md
File ansible/roles/gsm-tester-network/README.md:
Line 7: - `bts_interface` (eth1): on which network interface the bts is configured.
"the bts are"? It's definitely more than one. Also the octasic vs. the osmo-trx vs. the actual Abis/IP ones are fundamentally different, maybe the comment should be more concise about that.
https://gerrit.osmocom.org/#/c/7127/1/ansible/roles/gsm-tester-network/defaults/main.yml
File ansible/roles/gsm-tester-network/defaults/main.yml:
Line 3: bts_interface: eth1
(same) maybe the name should be abis_ip_bts_interface ?
https://gerrit.osmocom.org/#/c/7127/1/ansible/roles/gsm-tester-network/templates/interface.j2
File ansible/roles/gsm-tester-network/templates/interface.j2:
Line 2: auto {{ bts_interface }}
oh, so these are the IP addresses given to the various components like osmo-msc, osmo-bsc, osmo-mgw, and they should be IP addresses that are reachable from the BTSes. So then maybe the name should just be public_interface? Most of the time they are just IP addresses to give to a component so that we can tcpdump its communication separately. Only a few of the components actually communicate with a BTS directly.
--
To view, visit https://gerrit.osmocom.org/7127
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7007a4e6c38f73843390ec2b3b91133aff21e36a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes