Change in osmo-ttcn3-hacks[master]: bts: Extend Osmocom-specific RSL "supplementary meas info IE"

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Jun 29 17:53:10 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9778 )

Change subject: bts: Extend Osmocom-specific RSL "supplementary meas info IE"
......................................................................

bts: Extend Osmocom-specific RSL "supplementary meas info IE"

In osmo-bts Change-Id Iea4a4781481f77c6163d82dcd71a844a5be87bf2
we introduce an Osmocom specific "supplementary measurement info IE"
into the RSL MEAS REP message.  This commit adds the related type
definitions and extends the related matching in BTS_Tests.ttcn.

Change-Id: I5d1114c73508c67ad7cd9864d7370367612b1241
---
M bts/BTS_Tests.ttcn
M library/RSL_Types.ttcn
2 files changed, 16 insertions(+), 3 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 1044747..b77a70a 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -1240,8 +1240,13 @@
 		supp_meas_info := omit
 	};
 	if (l1p.toa256_enabled) {
-		ul_meas.len := 5;
-		ul_meas.supp_meas_info := int2oct(l1p.timing_offset_256syms, 2);
+		ul_meas.len := (3+8);
+		ul_meas.supp_meas_info := {
+			toa256_mean := l1p.timing_offset_256syms,
+			toa256_min := ?,
+			toa256_max := ?,
+			toa256_std_dev := ?
+		}
 	}
 	/* HACK HACK HACK FIXME HACK HACK HACK see https://osmocom.org/issues/2988 */
 	ul_meas.rxlev_f_u := ?;
diff --git a/library/RSL_Types.ttcn b/library/RSL_Types.ttcn
index e1f6af0..d4d0c4d 100644
--- a/library/RSL_Types.ttcn
+++ b/library/RSL_Types.ttcn
@@ -473,6 +473,14 @@
 		frame_nr := tr_RSL_IE_FrameNumber(frame_nr)
 	}
 
+	/* Osmocom Extension */
+	type record RSL_IE_UplinkMeasSuppMeasInfo {
+		int16_t toa256_mean,
+		int16_t toa256_min,
+		int16_t toa256_max,
+		uint16_t toa256_std_dev
+	};
+
 	/* 9.3.25 */
 	type record RSL_IE_UplinkMeas {
 		uint8_t len,
@@ -484,7 +492,7 @@
 		BIT2 reserved2,
 		uint3_t rxq_f_u,
 		uint3_t rxq_s_u,
-		octetstring supp_meas_info optional
+		RSL_IE_UplinkMeasSuppMeasInfo supp_meas_info optional
 	} with { variant (len) "LENGTHTO(rfu,dtx_d,rxlev_f_u,reserved1,rxlev_s_u,reserved2,rxq_f_u,rxq_s_u,supp_meas_info)" };
 
 	/* 9.3.26 */

-- 
To view, visit https://gerrit.osmocom.org/9778
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d1114c73508c67ad7cd9864d7370367612b1241
Gerrit-Change-Number: 9778
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180629/00fca315/attachment.htm>


More information about the gerrit-log mailing list