Change in openbsc[master]: Init access_lists before passing it as a parameter

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu Jun 28 15:24:09 UTC 2018


Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/9771


Change subject: Init access_lists before passing it as a parameter
......................................................................

Init access_lists before passing it as a parameter

Previous state is harmless because the pointer is stored but not used in
that function. However, it's more clear this way.

Back-port from osmo-bsc.git 9ab47eb52da73d25c4f94869385a4f836032362a.

Change-Id: Ic17c38578587a774da29266302e7b201ecacd3a3
---
M openbsc/src/osmo-bsc/osmo_bsc_main.c
1 file changed, 1 insertion(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/71/9771/1

diff --git a/openbsc/src/osmo-bsc/osmo_bsc_main.c b/openbsc/src/osmo-bsc/osmo_bsc_main.c
index be24cbd..e081fe9 100644
--- a/openbsc/src/osmo-bsc/osmo_bsc_main.c
+++ b/openbsc/src/osmo-bsc/osmo_bsc_main.c
@@ -61,7 +61,7 @@
 static const char *rf_ctrl = NULL;
 extern const char *openbsc_copyright;
 static int daemonize = 0;
-static struct llist_head access_lists;
+static LLIST_HEAD(access_lists);
 
 struct llist_head *bsc_access_lists(void)
 {
@@ -223,8 +223,6 @@
 	bsc_msg_lst_vty_init(tall_bsc_ctx, &access_lists, BSC_NODE);
 	ctrl_vty_init(tall_bsc_ctx);
 
-	INIT_LLIST_HEAD(&access_lists);
-
 	/* parse options */
 	handle_options(argc, argv);
 

-- 
To view, visit https://gerrit.osmocom.org/9771
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic17c38578587a774da29266302e7b201ecacd3a3
Gerrit-Change-Number: 9771
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180628/662cb693/attachment.htm>


More information about the gerrit-log mailing list