Change in osmo-bsc[master]: filter: vty: Print policy list in cmd show access-list

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Jun 28 13:43:32 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9765 )

Change subject: filter: vty: Print policy list in cmd show access-list
......................................................................

filter: vty: Print policy list in cmd show access-list

Change-Id: I3761819fb29f6fe49995ce4c1ae0e9bf92f993cd
---
M src/libfilter/bsc_msg_vty.c
1 file changed, 17 insertions(+), 16 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/libfilter/bsc_msg_vty.c b/src/libfilter/bsc_msg_vty.c
index 9905365..b26f4f1 100644
--- a/src/libfilter/bsc_msg_vty.c
+++ b/src/libfilter/bsc_msg_vty.c
@@ -26,6 +26,22 @@
 static struct llist_head *_acc_lst;
 static void *_ctx;
 
+static void bsc_msg_acc_lst_write_one(struct vty *vty, struct bsc_msg_acc_lst *lst)
+{
+	struct bsc_msg_acc_lst_entry *entry;
+
+	llist_for_each_entry(entry, &lst->fltr_list, list) {
+		if (entry->imsi_allow)
+			vty_out(vty, " access-list %s imsi-allow %s%s",
+				lst->name, entry->imsi_allow, VTY_NEWLINE);
+		if (entry->imsi_deny)
+			vty_out(vty, " access-list %s imsi-deny %s %d %d%s",
+				lst->name, entry->imsi_deny,
+				entry->cm_reject_cause, entry->lu_reject_cause,
+				VTY_NEWLINE);
+	}
+}
+
 DEFUN(cfg_lst_no,
       cfg_lst_no_cmd,
       "no access-list NAME",
@@ -52,6 +68,7 @@
 		return CMD_WARNING;
 
 	vty_out(vty, "access-list %s%s", acc->name, VTY_NEWLINE);
+	bsc_msg_acc_lst_write_one(vty, acc);
 	vty_out_rate_ctr_group(vty, " ", acc->stats);
 
 	return CMD_SUCCESS;
@@ -111,22 +128,6 @@
 	return CMD_SUCCESS;
 }
 
-static void bsc_msg_acc_lst_write_one(struct vty *vty, struct bsc_msg_acc_lst *lst)
-{
-	struct bsc_msg_acc_lst_entry *entry;
-
-	llist_for_each_entry(entry, &lst->fltr_list, list) {
-		if (entry->imsi_allow)
-			vty_out(vty, " access-list %s imsi-allow %s%s",
-				lst->name, entry->imsi_allow, VTY_NEWLINE);
-		if (entry->imsi_deny)
-			vty_out(vty, " access-list %s imsi-deny %s %d %d%s",
-				lst->name, entry->imsi_deny,
-				entry->cm_reject_cause, entry->lu_reject_cause,
-				VTY_NEWLINE);
-	}
-}
-
 void bsc_msg_acc_lst_write(struct vty *vty)
 {
 	struct bsc_msg_acc_lst *lst;

-- 
To view, visit https://gerrit.osmocom.org/9765
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3761819fb29f6fe49995ce4c1ae0e9bf92f993cd
Gerrit-Change-Number: 9765
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180628/a195174f/attachment.htm>


More information about the gerrit-log mailing list