Change in osmo-ttcn3-hacks[master]: bsc: fix TC_{early, late}_conn_fail: dyn PDCH: clean up cfg

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Jun 27 11:19:03 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9748 )

Change subject: bsc: fix TC_{early,late}_conn_fail: dyn PDCH: clean up cfg
......................................................................

bsc: fix TC_{early,late}_conn_fail: dyn PDCH: clean up cfg

When leaving TS 6 in Osmocom style dyn TS mode, the initialization of the BTS
will cause a RSL Chan Activ, which the tests BSC_Tests.TC_early_conn_fail and
BSC_Tests.TC_late_conn_fail will interpret as the channel activation that they
expect to come from the Channel Request. They will hence issue the Conn Fail
message before the lchan is established, and are getting confused on what they
expect to happen.

Change-Id: I2bde987eefe7129c9f7c3b81b624d55cb66a75d0
---
M bsc/BSC_Tests.ttcn
1 file changed, 12 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index 0107091..328fc59 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -2346,6 +2346,9 @@
 	f_sleep(1.0);
 	f_ts_dyn_mode_assert(0, 0, chan_nr.tn, TCHF_MODE);
 
+	/* clean up config */
+	f_ts_set_chcomb(0, 0, 6, "PDCH");
+
 	setverdict(pass);
 }
 
@@ -2380,6 +2383,9 @@
 	f_sleep(1.0);
 	f_ts_dyn_mode_assert(0, 0, chan_nr.tn, TCHF_MODE);
 
+	/* clean up config */
+	f_ts_set_chcomb(0, 0, 6, "PDCH");
+
 	setverdict(pass);
 }
 
@@ -2444,6 +2450,9 @@
 	f_sleep(1.0);
 	f_ts_dyn_mode_assert(0, 0, chan_nr.tn, PDCH_MODE);
 
+	/* clean up config */
+	f_ts_set_chcomb(0, 0, 6, "PDCH");
+
 	setverdict(pass);
 }
 
@@ -2470,6 +2479,9 @@
 	f_sleep(1.0);
 	f_ts_dyn_mode_assert(0, 0, chan_nr.tn, NONE_MODE);
 
+	/* clean up config */
+	f_ts_set_chcomb(0, 0, 6, "PDCH");
+
 	setverdict(pass);
 }
 

-- 
To view, visit https://gerrit.osmocom.org/9748
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2bde987eefe7129c9f7c3b81b624d55cb66a75d0
Gerrit-Change-Number: 9748
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180627/3c8ccc5e/attachment.htm>


More information about the gerrit-log mailing list