Change in libosmocore[master]: return error to sender upon bssgp_tlv_parse() failure

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Stefan Sperling gerrit-no-reply at lists.osmocom.org
Mon Jun 25 11:05:01 UTC 2018


Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/9730 )

Change subject: return error to sender upon bssgp_tlv_parse() failure
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/9730/1/src/gb/gprs_bssgp.c
File src/gb/gprs_bssgp.c:

https://gerrit.osmocom.org/#/c/9730/1/src/gb/gprs_bssgp.c@1035
PS1, Line 1035: 	uint8_t pdu_type = bgph->pdu_type;
> I'm not sure if a STATUS message can ever be present in this code path. […]
Indeed, good point.

We could probably drop some other messages, such as various ACKs. But at a minimum we must avoid a STATUS loop.
Fixed in updated patch set.



-- 
To view, visit https://gerrit.osmocom.org/9730
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If73719b75a94d6742bdefc9b6572525cb00a96ee
Gerrit-Change-Number: 9730
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Mon, 25 Jun 2018 11:05:01 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180625/66609561/attachment.htm>


More information about the gerrit-log mailing list