Change in libosmocore[master]: return error to sender upon bssgp_tlv_parse() failure

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Stefan Sperling gerrit-no-reply at lists.osmocom.org
Mon Jun 25 10:44:33 UTC 2018


Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/9730


Change subject: return error to sender upon bssgp_tlv_parse() failure
......................................................................

return error to sender upon bssgp_tlv_parse() failure

Return an error notification to the sender in case
bssgp_tlv_parse() failed.

Change-Id: If73719b75a94d6742bdefc9b6572525cb00a96ee
Related: OS#3178
---
M src/gb/gprs_bssgp.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/30/9730/1

diff --git a/src/gb/gprs_bssgp.c b/src/gb/gprs_bssgp.c
index 1445a56..e44694d 100644
--- a/src/gb/gprs_bssgp.c
+++ b/src/gb/gprs_bssgp.c
@@ -1052,7 +1052,7 @@
 	if (rc < 0) {
 		LOGP(DBSSGP, LOGL_ERROR, "Failed to parse BSSGP %s message. Invalid message was: %s\n",
 		     bssgp_pdu_str(pdu_type), msgb_hexdump(msg));
-		return rc;
+		return bssgp_tx_status(BSSGP_CAUSE_PROTO_ERR_UNSPEC, NULL, msg);
 	}
 
 	if (bvci == BVCI_SIGNALLING && TLVP_PRESENT(&tp, BSSGP_IE_BVCI))

-- 
To view, visit https://gerrit.osmocom.org/9730
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If73719b75a94d6742bdefc9b6572525cb00a96ee
Gerrit-Change-Number: 9730
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180625/7e1ad93b/attachment.htm>


More information about the gerrit-log mailing list