Change in osmo-ttcn3-hacks[master]: msc/USSD: introduce common GSUP/BSSAP matching functions

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Jun 25 10:33:25 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9687 )

Change subject: msc/USSD: introduce common GSUP/BSSAP matching functions
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/9687/3/msc/MSC_Tests.ttcn
File msc/MSC_Tests.ttcn:

https://gerrit.osmocom.org/#/c/9687/3/msc/MSC_Tests.ttcn@2133
PS3, Line 2133: bssap_msg
you call the function "expect_mt_bssap_msg" and you pass in a bssap_msg.  Yet then in the receive below you use a tr_PDU_DTAP_MT() which seems to imply that it's actually only for DTAP?



-- 
To view, visit https://gerrit.osmocom.org/9687
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I846c2d40a7c37afa8647e644673b4df905e3e116
Gerrit-Change-Number: 9687
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Mon, 25 Jun 2018 10:33:25 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180625/093afa3d/attachment.htm>


More information about the gerrit-log mailing list