This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9728 ) Change subject: check bssgp_tlv_parse() return code in gprs_bssgp_pcu_rcvmsg() ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/9728/1/src/gprs_bssgp_pcu.cpp File src/gprs_bssgp_pcu.cpp: https://gerrit.osmocom.org/#/c/9728/1/src/gprs_bssgp_pcu.cpp@392 PS1, Line 392: LOGP(DBSSGP, LOGL_ERROR, "Failed to parse BSSGP %s message. Invalid message was: %s\n", I think it's wise to not only log the message but also send a BSSGP STATUS PDU. Section 9 of TS 48.018 defines which error codes to send depending on the type of error. Even if we cannot distinguish betweeon those error cases, I think it's better to send a STATUS at all [even with a not so clear cause value] than to silently ignore it. At least we give the SGSN [operator] a chance to see that something is not working. -- To view, visit https://gerrit.osmocom.org/9728 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56e10a97cda7fd2d40bc7b4b2e6202f97772e1b3 Gerrit-Change-Number: 9728 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 25 Jun 2018 10:28:58 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180625/f924466f/attachment.htm>