Change in osmo-ttcn3-hacks[master]: msc/USSD: drop the TC_lu_and_ussd_wrong_code test case

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9683 )

Change subject: msc/USSD: drop the TC_lu_and_ussd_wrong_code test case
......................................................................

msc/USSD: drop the TC_lu_and_ussd_wrong_code test case

As we are about to finish the implementation of GSM TS 09.11, in
our case it is 'SS/USSD over GSUP', OsmoMSC will not decide itself
which USSD request-code is known, and which is wrong.

Change-Id: Ic104a49bb2dce2127063bcef8443ee6b639c9f19
---
M msc/MSC_Tests.ttcn
M msc/expected-results.xml
2 files changed, 0 insertions(+), 55 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index 3316563..ce95ff5 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -2163,59 +2163,6 @@
 	vc_conn.done;
 }
 
-private function f_tc_lu_and_ussd_wrong_code(charstring id, BSC_ConnHdlrPars pars)
-runs on BSC_ConnHdlr {
-	f_init_handler(pars);
-
-	/* Perform location update */
-	f_perform_lu();
-
-	/* Send CM Service Request for SS/USSD */
-	f_establish_fully(EST_TYPE_SS_ACT);
-
-	/* Compose a new SS/REGISTER message with request */
-	var template (value) PDU_ML3_MS_NW ussd_req := ts_ML3_MO_SS_REGISTER(
-		tid := 1, /* We just need a single transaction */
-		ti_flag := c_TIF_ORIG, /* Sent from the side that originates the TI */
-		facility := f_USSD_FACILITY_IE_INVOKE(
-			invoke_id := 5, /* Phone may not start from 0 or 1 */
-			op_code := SS_OP_CODE_PROCESS_USS_REQ,
-			ussd_string := "*#999#"
-		)
-	);
-
-	/* Compose SS/RELEASE_COMPLETE template with expected response */
-	var template PDU_ML3_NW_MS ussd_rsp := tr_ML3_MT_SS_RELEASE_COMPLETE(
-		tid := 1, /* Response should arrive within the same transaction */
-		ti_flag := c_TIF_REPL, /* Sent to the side that originates the TI */
-		facility := f_USSD_FACILITY_IE_RETURN_ERROR(
-			invoke_id := 5, /* InvokeID shall be the same for both REQ and RSP */
-			err_code := SS_ERR_CODE_UNEXPECTED_DATA_VALUE
-		)
-	);
-
-	/* Request own number request */
-	BSSAP.send(ts_PDU_DTAP_MO(ussd_req));
-	alt {
-	/* We expect RELEASE_COMPLETE message with the response */
-	[] BSSAP.receive(tr_PDU_DTAP_MT(ussd_rsp)) {
-		setverdict(pass);
-		}
-	[] BSSAP.receive {
-		setverdict(fail, "Unknown/unexpected BSSAP received");
-		self.stop;
-		}
-	}
-
-	f_expect_clear();
-}
-testcase TC_lu_and_ussd_wrong_code() runs on MTC_CT {
-	var BSC_ConnHdlr vc_conn;
-	f_init();
-	vc_conn := f_start_handler(refers(f_tc_lu_and_ussd_wrong_code), 47);
-	vc_conn.done;
-}
-
 /* LU followed by MT call and USSD request during this call */
 private function f_tc_lu_and_ussd_during_call(charstring id, BSC_ConnHdlrPars pars)
 runs on BSC_ConnHdlr {
@@ -2365,7 +2312,6 @@
 	execute( TC_smpp_mt_sms() );
 
 	execute( TC_lu_and_ussd_single_req() );
-	execute( TC_lu_and_ussd_wrong_code() );
 	execute( TC_lu_and_ussd_during_call() );
 
 	/* Run this last: at the time of writing this test crashes the MSC */
diff --git a/msc/expected-results.xml b/msc/expected-results.xml
index ba40519..8beab26 100644
--- a/msc/expected-results.xml
+++ b/msc/expected-results.xml
@@ -72,6 +72,5 @@
   <testcase classname='MSC_Tests' name='TC_smpp_mt_sms' time='MASKED'/>
   <testcase classname='MSC_Tests' name='TC_lu_imsi_auth_tmsi_encr_3_1_log_msc_debug' time='MASKED'/>
   <testcase classname='MSC_Tests' name='TC_lu_and_ussd_single_req' time='MASKED'/>
-  <testcase classname='MSC_Tests' name='TC_lu_and_ussd_wrong_code' time='MASKED'/>
   <testcase classname='MSC_Tests' name='TC_lu_and_ussd_during_call' time='MASKED'/>
 </testsuite>

-- 
To view, visit https://gerrit.osmocom.org/9683
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic104a49bb2dce2127063bcef8443ee6b639c9f19
Gerrit-Change-Number: 9683
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180623/9a1f1c04/attachment.htm>