This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.orgVadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/9704 ) Change subject: octphy: add support for 16x oversampling mode ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/9704/1/include/osmo-bts/phy_link.h File include/osmo-bts/phy_link.h: https://gerrit.osmocom.org/#/c/9704/1/include/osmo-bts/phy_link.h@77 PS1, Line 77: uint32_t over_sample_16x; It seems this variable is going to be used as a flag (0 or 1), so do we really need 4-bytes to store such big range?? I think 'bool' is more suitable here. -- To view, visit https://gerrit.osmocom.org/9704 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib78f92bfe03ff20aa0a257763c90844fb7b87cf0 Gerrit-Change-Number: 9704 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: Harald Welte <laforge at gnumonks.org> Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Comment-Date: Fri, 22 Jun 2018 12:58:26 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180622/c764b5f1/attachment.htm>