This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9701 )
Change subject: Drop unused common_vty.c
......................................................................
Drop unused common_vty.c
Change-Id: I19f1ece5f2f62d1f8f40a9b9d0c6c41ad05e5c76
---
M debian/copyright
M src/libcommon/Makefile.am
D src/libcommon/common_vty.c
3 files changed, 0 insertions(+), 143 deletions(-)
Approvals:
Jenkins Builder: Verified
Vadim Yanitskiy: Looks good to me, but someone else must approve
Harald Welte: Looks good to me, approved
diff --git a/debian/copyright b/debian/copyright
index 8094f2a..65f3ba7 100644
--- a/debian/copyright
+++ b/debian/copyright
@@ -123,7 +123,6 @@
src/gprs/sgsn_libgtp.c
src/gprs/sgsn_main.c
src/gprs/sgsn_vty.c
- src/libcommon/common_vty.c
src/libcommon/debug.c
src/libcommon/gsm_data.c
src/libcommon/gsm_data_shared.c
diff --git a/src/libcommon/Makefile.am b/src/libcommon/Makefile.am
index 737265b..69fb37d 100644
--- a/src/libcommon/Makefile.am
+++ b/src/libcommon/Makefile.am
@@ -18,7 +18,6 @@
$(NULL)
libcommon_a_SOURCES = \
- common_vty.c \
debug.c \
gsm_data.c \
gsm_data_shared.c \
diff --git a/src/libcommon/common_vty.c b/src/libcommon/common_vty.c
deleted file mode 100644
index 6534105..0000000
--- a/src/libcommon/common_vty.c
+++ /dev/null
@@ -1,141 +0,0 @@
-/* OpenBSC VTY common helpers */
-/* (C) 2009-2010 by Harald Welte <laforge at gnumonks.org>
- * (C) 2009-2010 by Holger Hans Peter Freyther
- * All Rights Reserved
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU Affero General Public License as published by
- * the Free Software Foundation; either version 3 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU Affero General Public License for more details.
- *
- * You should have received a copy of the GNU Affero General Public License
- * along with this program. If not, see <http://www.gnu.org/licenses/>.
- *
- */
-
-#include <stdlib.h>
-#include <string.h>
-
-#include <osmocom/core/talloc.h>
-
-#include <osmocom/sgsn/vty.h>
-#include <osmocom/sgsn/debug.h>
-#include <osmocom/sgsn/gsm_subscriber.h>
-#include <osmocom/sgsn/bsc_nat.h>
-#include <osmocom/sgsn/abis_om2000.h>
-
-#include <osmocom/vty/telnet_interface.h>
-#include <osmocom/vty/command.h>
-#include <osmocom/vty/buffer.h>
-#include <osmocom/vty/vty.h>
-
-
-int bsc_vty_go_parent(struct vty *vty)
-{
- switch (vty->node) {
- case GSMNET_NODE:
- vty->node = CONFIG_NODE;
- vty->index = NULL;
- break;
- case BTS_NODE:
- vty->node = GSMNET_NODE;
- {
- /* set vty->index correctly ! */
- struct gsm_bts *bts = vty->index;
- vty->index = bts->network;
- vty->index_sub = NULL;
- }
- break;
- case TRX_NODE:
- vty->node = BTS_NODE;
- {
- /* set vty->index correctly ! */
- struct gsm_bts_trx *trx = vty->index;
- vty->index = trx->bts;
- vty->index_sub = &trx->bts->description;
- }
- break;
- case TS_NODE:
- vty->node = TRX_NODE;
- {
- /* set vty->index correctly ! */
- struct gsm_bts_trx_ts *ts = vty->index;
- vty->index = ts->trx;
- vty->index_sub = &ts->trx->description;
- }
- break;
- case OML_NODE:
- case OM2K_NODE:
- vty->node = ENABLE_NODE;
- /* NOTE: this only works because it's not part of the config
- * tree, where outer commands are searched via vty_go_parent()
- * and only (!) executed when a matching one is found.
- */
- talloc_free(vty->index);
- vty->index = NULL;
- break;
- case OM2K_CON_GROUP_NODE:
- vty->node = BTS_NODE;
- {
- struct con_group *cg = vty->index;
- struct gsm_bts *bts = cg->bts;
- vty->index = bts;
- vty->index_sub = &bts->description;
- }
- break;
- case NAT_BSC_NODE:
- vty->node = NAT_NODE;
- {
- struct bsc_config *bsc_config = vty->index;
- vty->index = bsc_config->nat;
- }
- break;
- case PGROUP_NODE:
- vty->node = NAT_NODE;
- vty->index = NULL;
- break;
- case GBPROXY_NODE:
- case SGSN_NODE:
- case NAT_NODE:
- case BSC_NODE:
- case MSC_NODE:
- case MNCC_INT_NODE:
- case NITB_NODE:
- vty->node = CONFIG_NODE;
- vty->index = NULL;
- break;
- case SUBSCR_NODE:
- vty->node = ENABLE_NODE;
- vty->index = NULL;
- break;
- default:
- osmo_ss7_vty_go_parent(vty);
- }
-
- return vty->node;
-}
-
-int bsc_vty_is_config_node(struct vty *vty, int node)
-{
- /* Check if libosmo-sccp declares the node in
- * question as config node */
- if (osmo_ss7_is_config_node(vty, node))
- return 1;
-
- switch (node) {
- /* add items that are not config */
- case OML_NODE:
- case OM2K_NODE:
- case SUBSCR_NODE:
- case CONFIG_NODE:
- return 0;
-
- default:
- return 1;
- }
-}
--
To view, visit https://gerrit.osmocom.org/9701
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I19f1ece5f2f62d1f8f40a9b9d0c6c41ad05e5c76
Gerrit-Change-Number: 9701
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180622/eb6f03d3/attachment.htm>