Change in osmo-sgsn[master]: Drop all references of unused SMPP

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Jun 22 07:21:24 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9699 )

Change subject: Drop all references of unused SMPP
......................................................................

Drop all references of unused SMPP

Change-Id: Iffae03fd855e6cbd99e71b9ba0d4157cb7791db2
---
M contrib/jenkins.sh
M include/osmocom/sgsn/debug.h
M src/libcommon/common_vty.c
M src/libcommon/debug.c
4 files changed, 2 insertions(+), 13 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index e60e8a5..931d14c 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -49,12 +49,12 @@
 
 cd "$base"
 autoreconf --install --force
-./configure --enable-sanitize $enable_werror $SMPP $MGCP $IU --enable-external-tests
+./configure --enable-sanitize $enable_werror $MGCP $IU --enable-external-tests
 $MAKE $PARALLEL_MAKE
 LD_LIBRARY_PATH="$inst/lib" $MAKE check \
   || cat-testlogs.sh
 LD_LIBRARY_PATH="$inst/lib" \
-  DISTCHECK_CONFIGURE_FLAGS="$enable_werror $SMPP $MGCP $IU --enable-external-tests" \
+  DISTCHECK_CONFIGURE_FLAGS="$enable_werror $MGCP $IU --enable-external-tests" \
   $MAKE distcheck \
   || cat-testlogs.sh
 
diff --git a/include/osmocom/sgsn/debug.h b/include/osmocom/sgsn/debug.h
index 65e197d..eed2921 100644
--- a/include/osmocom/sgsn/debug.h
+++ b/include/osmocom/sgsn/debug.h
@@ -31,7 +31,6 @@
 	DSLHC,
 	DNAT,
 	DCTRL,
-	DSMPP,
 	DFILTER,
 	DGTPHUB,
 	DRANAP,
diff --git a/src/libcommon/common_vty.c b/src/libcommon/common_vty.c
index e960550..7b80bcb 100644
--- a/src/libcommon/common_vty.c
+++ b/src/libcommon/common_vty.c
@@ -103,11 +103,6 @@
 		vty->node = MGCP_NODE;
 		vty->index = NULL;
 		break;
-	case SMPP_ESME_NODE:
-		vty->node = SMPP_NODE;
-		vty->index = NULL;
-		break;
-	case SMPP_NODE:
 	case MGCP_NODE:
 	case GBPROXY_NODE:
 	case SGSN_NODE:
diff --git a/src/libcommon/debug.c b/src/libcommon/debug.c
index 6076409..06653a9 100644
--- a/src/libcommon/debug.c
+++ b/src/libcommon/debug.c
@@ -154,11 +154,6 @@
 		.description = "Control interface",
 		.enabled = 1, .loglevel = LOGL_NOTICE,
 	},
-	[DSMPP] = {
-		.name = "DSMPP",
-		.description = "SMPP interface for external SMS apps",
-		.enabled = 1, .loglevel = LOGL_DEBUG,
-	},
 	[DFILTER] = {
 		.name = "DFILTER",
 		.description = "BSC/NAT IMSI based filtering",

-- 
To view, visit https://gerrit.osmocom.org/9699
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iffae03fd855e6cbd99e71b9ba0d4157cb7791db2
Gerrit-Change-Number: 9699
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180622/acad4660/attachment.htm>


More information about the gerrit-log mailing list