Change in osmo-msc[master]: jenkins.sh: Use --enable-werror only when iu support is disabled

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Jun 21 17:12:41 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9695 )

Change subject: jenkins.sh: Use --enable-werror only when iu support is disabled
......................................................................

jenkins.sh: Use --enable-werror only when iu support is disabled

The flag cannot be enabled in all cases because current osmo-iuh header
contain compilation warnings which are then propagated to this project
when building against them.

Change-Id: I799ae49567c8e9ff7a98d296873ac0b12e926558
---
M contrib/jenkins.sh
1 file changed, 5 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index d80422d..c09c368 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -31,10 +31,13 @@
 PARALLEL_MAKE="" osmo-build-dep.sh libsmpp34
 osmo-build-dep.sh osmo-mgw
 
+enable_werror=""
 if [ "x$IU" = "x--enable-iu" ]; then
 	osmo-build-dep.sh libasn1c
 	#osmo-build-dep.sh asn1c aper-prefix # only needed for make regen in osmo-iuh
 	osmo-build-dep.sh osmo-iuh
+else
+	enable_werror="--enable-werror"
 fi
 
 set +x
@@ -47,12 +50,12 @@
 
 cd "$base"
 autoreconf --install --force
-./configure --enable-sanitize --enable-smpp $IU --enable-external-tests
+./configure --enable-sanitize $enable_werror --enable-smpp $IU --enable-external-tests
 $MAKE $PARALLEL_MAKE
 LD_LIBRARY_PATH="$inst/lib" $MAKE check \
   || cat-testlogs.sh
 LD_LIBRARY_PATH="$inst/lib" \
-  DISTCHECK_CONFIGURE_FLAGS="--enable-smpp $IU --enable-external-tests" \
+  DISTCHECK_CONFIGURE_FLAGS="$enable_werror --enable-smpp $IU --enable-external-tests" \
   $MAKE distcheck \
   || cat-testlogs.sh
 

-- 
To view, visit https://gerrit.osmocom.org/9695
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I799ae49567c8e9ff7a98d296873ac0b12e926558
Gerrit-Change-Number: 9695
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180621/79908be5/attachment.htm>


More information about the gerrit-log mailing list