Change in osmo-ttcn3-hacks[master]: msc/USSD: add test cases with network-initiaded SS/USSD

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Jun 20 07:50:58 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9686 )

Change subject: msc/USSD: add test cases with network-initiaded SS/USSD
......................................................................


Patch Set 1:

(1 comment)

I love your work on the tests.  We can just redoce verbosity and number of copy+paste by using more TTCN3 language features. Thanks!

https://gerrit.osmocom.org/#/c/9686/1/msc/MSC_Tests.ttcn
File msc/MSC_Tests.ttcn:

https://gerrit.osmocom.org/#/c/9686/1/msc/MSC_Tests.ttcn@2257
PS1, Line 2257: 	[] BSSAP.receive {
those "alt" clauses are identical and copy+pasted several times below.  You should abstract those out into one or two altsteps and then either
a) call the altstep explicitly, i.e. "[] as_fail_on_gsup()", or
b) activating it/them as "default" so they become an implicit part of every "alt" or even stand-alone receive statement



-- 
To view, visit https://gerrit.osmocom.org/9686
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I073893c6e11be27e9e36f98f11c1491d0c173985
Gerrit-Change-Number: 9686
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Wed, 20 Jun 2018 07:50:58 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180620/da788284/attachment.htm>


More information about the gerrit-log mailing list