Change in osmo-trx[master]: lms: Allow values diff than 34dB to be set by setRxGain()

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9678 )

Change subject: lms: Allow values diff than 34dB to be set by setRxGain()
......................................................................

lms: Allow values diff than 34dB to be set by setRxGain()

Until now, setRxGain in LMSDevice did not take into account the setter
parameter and was always using hardcoded 34dB, which was experimentally
found to be a good default value.

Let's force that value during initialization, but still allow the upper
layers (controlled by BTS) to set different values. osmo-bts only sends
a SETRXGAIN command (which calls setRxGain in osmo-trx) if a value is
explicitly set in its VTY config, so we are on the safe side if the user
doesn't explicitly configure a desired dB.

Change-Id: I5684e675281a3f581855dbb56d199a6fe238a712
---
M Transceiver52M/device/lms/LMSDevice.cpp
1 file changed, 1 insertion(+), 3 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/Transceiver52M/device/lms/LMSDevice.cpp b/Transceiver52M/device/lms/LMSDevice.cpp
index 16585e6..ffea505 100644
--- a/Transceiver52M/device/lms/LMSDevice.cpp
+++ b/Transceiver52M/device/lms/LMSDevice.cpp
@@ -223,7 +223,7 @@
 
 		// Set gains to midpoint
 		setTxGain((minTxGain() + maxTxGain()) / 2, i);
-		setRxGain((minRxGain() + maxRxGain()) / 2, i);
+		setRxGain(34.0, i);
 
 		m_lms_stream_rx[i] = {};
 		m_lms_stream_rx[i].isTx = false;
@@ -327,8 +327,6 @@
 		return 0.0;
 	}
 
-	dB = 34.0;
-
 	if (dB > maxRxGain())
 		dB = maxRxGain();
 	if (dB < minRxGain())

-- 
To view, visit https://gerrit.osmocom.org/9678
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5684e675281a3f581855dbb56d199a6fe238a712
Gerrit-Change-Number: 9678
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180620/6cd7e09c/attachment.htm>