Change in osmo-ttcn3-hacks[master]: bsc: inter-BSC HO: add TC_ho_out_of_this_bsc, TC_ho_into_this_bsc

[Harald Welte]

Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9674 )

Change subject: bsc: inter-BSC HO: add TC_ho_out_of_this_bsc, TC_ho_into_this_bsc
......................................................................


Patch Set 1:

(5 comments)

https://gerrit.osmocom.org/#/c/9674/1/bsc/BSC_Tests.ttcn
File bsc/BSC_Tests.ttcn:

https://gerrit.osmocom.org/#/c/9674/1/bsc/BSC_Tests.ttcn@2492
PS1, Line 2492: template PDU_BSSAP tr_BSSMAP_HandoverRequired modifies tr_BSSAP_BSSMAP := {
should go to BSSMAP_Templates.ttcn


https://gerrit.osmocom.org/#/c/9674/1/bsc/BSC_Tests.ttcn@2502
PS1, Line 2502: template PDU_BSSAP ts_BSSMAP_HandoverCommand(octetstring layer3info) modifies ts_BSSAP_BSSMAP := {
should go to BSSMAP_Templates.ttcn and should be a template (value) PDU_BSSAP if it's for sending.


https://gerrit.osmocom.org/#/c/9674/1/bsc/BSC_Tests.ttcn@2520
PS1, Line 2520: template PDU_ML3_NW_MS ts_RR_HandoverCommand := {
should be template (value) as it's a send template, and should go into L3_Templates.ttcn


https://gerrit.osmocom.org/#/c/9674/1/bsc/BSC_Tests.ttcn@2668
PS1, Line 2668: template PDU_BSSAP ts_BSSMAP_HandoverRequest(
template (value) and BSSMAP_Templates.ttcn


https://gerrit.osmocom.org/#/c/9674/1/bsc/BSC_Tests.ttcn@2726
PS1, Line 2726: template PDU_BSSAP tr_BSSMAP_HandoverRequestAcknowledge(octetstring layer3info)
BSSMAP_Templates.ttcn



-- 
To view, visit https://gerrit.osmocom.org/9674
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id22852d4be7f127d827e7a8beeec55db27c07f03
Gerrit-Change-Number: 9674
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Mon, 18 Jun 2018 10:11:40 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180618/7922c669/attachment.htm>