Change in osmo-ci[master]: verify_value_string_arrays_are_terminated.py: allow terminating with ...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Sat Jun 16 13:46:41 UTC 2018


Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/9543 )

Change subject: verify_value_string_arrays_are_terminated.py: allow terminating with '{}'
......................................................................

verify_value_string_arrays_are_terminated.py: allow terminating with '{}'

Writing '{ 0, NULL }' is actually identical to just '{}', and that's what I use
these days in all sorts of other contexts. So allow this notation as well in
the C code grepper.

Change-Id: I0822d2d997dccbfb31316953a7b6024c317d92cf
---
M scripts/verify_value_string_arrays_are_terminated.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Neels Hofmeyr: Verified



diff --git a/scripts/verify_value_string_arrays_are_terminated.py b/scripts/verify_value_string_arrays_are_terminated.py
index 020bb4d..ad936a5 100755
--- a/scripts/verify_value_string_arrays_are_terminated.py
+++ b/scripts/verify_value_string_arrays_are_terminated.py
@@ -18,7 +18,7 @@
   re.MULTILINE | re.DOTALL)
 
 members = r'(\.(value|str)\s*=\s*)?'
-terminator_re = re.compile('{\s*' + members + '(0|NULL)\s*,'
+terminator_re = re.compile('{}|{\s*' + members + '(0|NULL)\s*,'
                            '\s*' + members + '(0|NULL)\s*}')
 errors_found = 0
 

-- 
To view, visit https://gerrit.osmocom.org/9543
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0822d2d997dccbfb31316953a7b6024c317d92cf
Gerrit-Change-Number: 9543
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180616/06c761d9/attachment.htm>


More information about the gerrit-log mailing list