Change in osmo-msc[master]: libmsc/ussd.c: use connection ref-counting and transactions

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun Jun 10 14:50:52 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/7699 )

Change subject: libmsc/ussd.c: use connection ref-counting and transactions
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/7699/2/src/libmsc/transaction.c
File src/libmsc/transaction.c:

https://gerrit.osmocom.org/#/c/7699/2/src/libmsc/transaction.c@132
PS2, Line 132: 		conn_usage_token = MSC_CONN_USE_TRANS_USSD;
is the naming wrong here? Would this token also be used for non-unstructured SS?  If yes, it might make sense to rename it?



-- 
To view, visit https://gerrit.osmocom.org/7699
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I21c6777cb88f1f4f80f75dcd39734e952bd4e8b0
Gerrit-Change-Number: 7699
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Sun, 10 Jun 2018 14:50:52 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180610/7dc7a7db/attachment.htm>


More information about the gerrit-log mailing list