This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
steve-m gerrit-no-reply at lists.osmocom.orgsteve-m has uploaded this change for review. ( https://gerrit.osmocom.org/9518 Change subject: trf6151: Actually fix setting of uplink ARFCN ...................................................................... trf6151: Actually fix setting of uplink ARFCN Some time ago a broken fix was committed which then has been reverted again in commit 17240037376169369b526ee8a8284961b85adbfa. The purpose of this line is to clear the uplink flag from the ARFCN. So far this worked because both gsm_arfcn2band() and gsm_arfcn2freq10() already do this internally. Change-Id: Ie8a05ffc0ddec53d7fd6a25e03ea285fb216df29 Signed-off-by: Steve Markgraf <steve at steve-m.de> --- M src/target/firmware/rf/trf6151.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/18/9518/1 diff --git a/src/target/firmware/rf/trf6151.c b/src/target/firmware/rf/trf6151.c index 0a91009..9de2cc8 100644 --- a/src/target/firmware/rf/trf6151.c +++ b/src/target/firmware/rf/trf6151.c @@ -436,7 +436,7 @@ enum trf6151_gsm_band pll_band; uplink = !!(arfcn & ARFCN_UPLINK); - arfcn != ~ARFCN_UPLINK; + arfcn &= ~ARFCN_UPLINK; switch (gsm_arfcn2band(arfcn)) { case GSM_BAND_850: -- To view, visit https://gerrit.osmocom.org/9518 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie8a05ffc0ddec53d7fd6a25e03ea285fb216df29 Gerrit-Change-Number: 9518 Gerrit-PatchSet: 1 Gerrit-Owner: steve-m <steve at steve-m.de> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180608/d2bed746/attachment.htm>