This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9486 ) Change subject: doc: tweak msc charts on Assignment/Handover: act_timer ...................................................................... doc: tweak msc charts on Assignment/Handover: act_timer Change-Id: I6205e43c227652432548c5c99bed5a197c095da2 --- M doc/assignment.msc M doc/handover.msc 2 files changed, 17 insertions(+), 2 deletions(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/doc/assignment.msc b/doc/assignment.msc index e2bdf84..d470d01 100644 --- a/doc/assignment.msc +++ b/doc/assignment.msc @@ -54,14 +54,17 @@ bsc_gscon abox bsc_gscon [label="ST_WAIT_ASS_COMPL (GSM0808_T10_VALUE=6s)"]; ...; bts note bsc_gscon [linecolor="red", - label="There seems to be no timer watching over Chan Release nor dyn TS switchover!"]; + label="Osmocom style dyn TS use lchan->act_timer to watch over RF Chan Release, but there + seems to be no timer watching over PDCH Deact!"]; ...; bts => bsc [label="i) RSL RF Chan Release ACK (Osmocom dyn TS)"]; bts => bsc [label="OR ii) RSL PDCH Deact ACK (ip.access dyn TS)"]; bsc box bsc [label="rsl_chan_activate_lchan() re-invoked"]; + bsc box bsc [label="lchan->state = LCHAN_S_ACT_REQ"]; bts <= bsc [label="RSL Chan Activ"]; --- [label="else (no dyn TS switchover)"]; + bsc box bsc [label="lchan->state = LCHAN_S_ACT_REQ"]; bts <= bsc [label="RSL Chan Activ"]; bsc -> bsc_gscon [label="gsm0808_assign_req() returns"]; bsc_gscon abox bsc_gscon [label="ST_WAIT_ASS_COMPL (GSM0808_T10_VALUE=6s)"]; @@ -79,6 +82,10 @@ ...; bts => bsc [label="RSL Chan Activ ACK"]; + bsc box bsc [label="rsl_rx_chan_act_ack()"]; + bsc box bsc [label="Stop lchan->act_timer"]; + bsc box bsc [label="lchan->state = LCHAN_S_ACTIVE"]; + bsc -> bsc [label="S_LCHAN_ACTIVATE_ACK"]; bsc box bsc [label="bsc_api.c handle_chan_ack()"]; ms <= bsc [label="RR Assignment Command"]; @@ -135,6 +142,8 @@ --- [label="End: 'On timeout'"]; ...; bts => bsc [label="RSL RF Channel Release Ack"]; + bsc box bsc [label="Stop lchan->act_timer"]; + bsc box bsc [label="Stop lchan->T3111"]; --- [label="End: 'Release old lchan'"]; bsc box bsc [label="still in handle_ass_compl()"]; bsc note bsc [label="officially take over new lchan: conn->lchan = conn->secondary_lchan"]; diff --git a/doc/handover.msc b/doc/handover.msc index e5e787c..8862dd9 100644 --- a/doc/handover.msc +++ b/doc/handover.msc @@ -20,7 +20,8 @@ bsc_gscon abox bsc_gscon [label="ST_WAIT_HO_COMPL (no timeout, relies on T3103 below)"]; ...; bts note bsc_gscon [linecolor="red", - label="There seems to be no timer watching over Chan Release nor dyn TS switchover!"]; + label="Osmocom style dyn TS use lchan->act_timer to watch over RF Chan Release, but there + seems to be no timer watching over PDCH Deact!"]; ...; bts => bsc [label="i) RSL RF Chan Release ACK (Osmocom dyn TS)"]; bts => bsc [label="OR ii) RSL PDCH Deact ACK (ip.access dyn TS)"]; @@ -38,6 +39,9 @@ label="There seems to be no timer watching out for RSL Chan Activ ACK/NACK!"]; ...; bts => bsc [label="RSL Chan Activ ACK"]; + bsc box bsc [label="rsl_rx_chan_act_ack()"]; + bsc box bsc [label="Stop lchan->act_timer"]; + bsc box bsc [label="lchan->state = LCHAN_S_ACTIVE"]; bsc -> bsc [label="S_LCHAN_ACTIVATE_ACK"]; bsc box bsc [label="handover_logic.c ho_logic_sig_cb()"]; bsc box bsc [label="ho_chan_activ_ack()"]; @@ -132,6 +136,8 @@ --- [label="End: 'On timeout'"]; ...; bts => bsc [label="RSL RF Channel Release Ack"]; + bsc box bsc [label="Stop lchan->act_timer"]; + bsc box bsc [label="Stop lchan->T3111"]; ---; bsc box bsc [label="still in ho_gsm48_ho_compl()"]; -- To view, visit https://gerrit.osmocom.org/9486 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I6205e43c227652432548c5c99bed5a197c095da2 Gerrit-Change-Number: 9486 Gerrit-PatchSet: 7 Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180608/ba664939/attachment.htm>