Change in libosmo-sccp[master]: fix infinite recursion with routing by global title

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Stefan Sperling gerrit-no-reply at lists.osmocom.org
Tue Jun 5 17:15:17 UTC 2018


Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/9463


Change subject: fix infinite recursion with routing by global title
......................................................................

fix infinite recursion with routing by global title

We don't implement routing by global title address.
When processing an SCCP message which is routed by global title,
don't recurs indefinitely until the stack is exhausted.
Instead, return an error with cause SUBSYSTEM_FAILURE, which we
also do in other routing failure cases.

Change-Id: I24621e77ffc979bc337775f9c6a4ad9a9068625a
Related: OS#2666
---
M src/sccp_scrc.c
1 file changed, 7 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/63/9463/1

diff --git a/src/sccp_scrc.c b/src/sccp_scrc.c
index dca5645..cd01774 100644
--- a/src/sccp_scrc.c
+++ b/src/sccp_scrc.c
@@ -279,8 +279,15 @@
 	    translated.ri != OSMO_SCCP_RI_SSN_IP) {
 		/* TODO: GT Routing */
 		LOGP(DLSCCP, LOGL_NOTICE, "GT Routing not implemented yet\n");
+#if 1
+		/* Prevent endless recursion, see OS#2666. */
+		sccp_sclc_rx_scrc_rout_fail(inst, xua,
+			SCCP_RETURN_CAUSE_SUBSYSTEM_FAILURE);
+		return 0;
+#else
 		/* Node 7 (Sheet 5) */
 		return scrc_node_7(inst, xua, called);
+#endif
 	}
 
 	/* Check DPC resultant from GT translation */

-- 
To view, visit https://gerrit.osmocom.org/9463
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I24621e77ffc979bc337775f9c6a4ad9a9068625a
Gerrit-Change-Number: 9463
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180605/a298ec17/attachment.htm>


More information about the gerrit-log mailing list