Change in osmo-iuh[master]: asn1tostruct: allow to override build date

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Jun 5 11:42:31 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9387 )

Change subject: asn1tostruct: allow to override build date
......................................................................

asn1tostruct: allow to override build date

in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.

Also do not record build user name to not have it vary.

Change-Id: I5cfa465cc82f009f28dd7f12ced0e72a05fda842
---
M asn1/utils/asn1tostruct.py
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  lynxis lazus: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/asn1/utils/asn1tostruct.py b/asn1/utils/asn1tostruct.py
index 0bba9dd..3c33980 100755
--- a/asn1/utils/asn1tostruct.py
+++ b/asn1/utils/asn1tostruct.py
@@ -4,6 +4,7 @@
 import datetime
 import getopt
 import getpass
+import time
 
 version = "0.5osmo1"
 
@@ -33,11 +34,11 @@
         print string
 
 def outputHeaderToFile(f, filename):
-    now = datetime.datetime.now()
+    now = datetime.datetime.utcfromtimestamp(int(os.environ.get('SOURCE_DATE_EPOCH', time.time())))
     f.write("/*******************************************************************************\n")
     f.write(" * This file had been created by asn1tostruct.py script v%s\n" % (version))
     f.write(" * Please do not modify this file but regenerate it via script.\n")
-    f.write(" * Created on: %s by %s\n * from %s\n" % (str(now), getpass.getuser(), filenames))
+    f.write(" * Created on: %s\n * from %s\n" % (str(now), filenames))
     f.write(" ******************************************************************************/\n")
 
 def lowerFirstCamelWord(word):

-- 
To view, visit https://gerrit.osmocom.org/9387
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5cfa465cc82f009f28dd7f12ced0e72a05fda842
Gerrit-Change-Number: 9387
Gerrit-PatchSet: 1
Gerrit-Owner: Bernhard M. <bwiedemann at suse.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180605/6badbe12/attachment.htm>


More information about the gerrit-log mailing list