Change in libosmo-sccp[master]: Introduce osmo_ss7_asp_rx_unknown() for handling unknown PPID/StreamID

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Jun 5 07:25:14 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9439 )

Change subject: Introduce osmo_ss7_asp_rx_unknown() for handling unknown PPID/StreamID
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/9439/1/src/osmo_ss7.c
File src/osmo_ss7.c:

https://gerrit.osmocom.org/#/c/9439/1/src/osmo_ss7.c@1923
PS1, Line 1923: __attribute__((weak))
the introduction of a weak symbol  for overloading is of course a bit controversial.  I'm not sure what others think about this.  We could of course also have a function pointer that can be overridden, or even have a function to register  a function pointer (callback).  What do you think?



-- 
To view, visit https://gerrit.osmocom.org/9439
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8616f914192000df0ec6547ff4ada80e0f9042a2
Gerrit-Change-Number: 9439
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Tue, 05 Jun 2018 07:25:14 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180605/9bce8f30/attachment.htm>


More information about the gerrit-log mailing list