Change in osmo-ci[master]: Revert "osmocom-latest-packages: Also accept "v" in front of version ...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Jun 4 12:09:26 UTC 2018


Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/9443


Change subject: Revert "osmocom-latest-packages: Also accept "v" in front of version tags"
......................................................................

Revert "osmocom-latest-packages: Also accept "v" in front of version tags"

This reverts commit 5b2bb86e8ada837732f06bb4a77779cdbca73496.

While it was intended to enable automatic "latest" builds from rtl-sdr,
it breaks builds e.g. of libosmo-abis, where we have both (new) tags
without  'v' and old tags with 'v', and now the older 'v' tags win
due to lexicographical sorting :(

Change-Id: I1c8d2ab18e389a8c2c41082d997f101d72c3acc0
---
M scripts/osmocom-latest-packages.sh
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/43/9443/1

diff --git a/scripts/osmocom-latest-packages.sh b/scripts/osmocom-latest-packages.sh
index 6f60ef8..e8d61a3 100755
--- a/scripts/osmocom-latest-packages.sh
+++ b/scripts/osmocom-latest-packages.sh
@@ -32,7 +32,7 @@
   [ -d "$1" ] || git clone "git://git.osmocom.org/$1"
   cd "$1"
   git fetch
-  VER=$(git tag -l --sort=v:refname | grep "^v\?[0-9]*.[0-9]*.[0-9]*$" | tail -n 1)
+  VER=$(git tag -l --sort=v:refname | grep "^[0-9]*.[0-9]*.[0-9]*$" | tail -n 1)
   git checkout -f -B "$VER" "refs/tags/$VER"
   gbp buildpackage -d -S -uc -us "--git-export-dir=$output" "--git-debian-branch=$VER"
 

-- 
To view, visit https://gerrit.osmocom.org/9443
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1c8d2ab18e389a8c2c41082d997f101d72c3acc0
Gerrit-Change-Number: 9443
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180604/23171ea6/attachment.htm>


More information about the gerrit-log mailing list