Change in osmocom-bb[master]: mobile/sms: Fix memory leak in case the storage can not be opened

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Sat Jun 2 11:15:35 UTC 2018


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/9417 )

Change subject: mobile/sms: Fix memory leak in case the storage can not be opened
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/9417/1/src/host/layer23/src/mobile/gsm411_sms.c
File src/host/layer23/src/mobile/gsm411_sms.c:

https://gerrit.osmocom.org/#/c/9417/1/src/host/layer23/src/mobile/gsm411_sms.c@213
PS1, Line 213: 	snprintf(sms_file, len, "%s/%s", home, osmocomsms);
Hmm, we also compose a similar path in main.c.
Probably, it makes sense to compose this path
once there, and store somewhere in ms->settings...



-- 
To view, visit https://gerrit.osmocom.org/9417
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifce2bc130fe3a5bd49ad457ee61002952dd496ba
Gerrit-Change-Number: 9417
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Sat, 02 Jun 2018 11:15:35 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180602/afe940b4/attachment.htm>


More information about the gerrit-log mailing list