This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10250 )
Change subject: Add osmo-euse-demo as minimalistic test of a External USSD (EUSE) handler
......................................................................
Patch Set 2: Code-Review-1
(3 comments)
https://gerrit.osmocom.org/#/c/10250/2/src/osmo-euse-demo.c
File src/osmo-euse-demo.c:
https://gerrit.osmocom.org/#/c/10250/2/src/osmo-euse-demo.c@1
PS2, Line 1: #include <string.h>
some description/intro required
https://gerrit.osmocom.org/#/c/10250/2/src/osmo-euse-demo.c@146
PS2, Line 146: //if (strlen(gsup_msg.imsi) < 5)
: //return gsup_send_err_reply(gsupc, gsup.imsi, gsup.message_type, GMM_CAUSE_INV_MAND_INFO);
remove
https://gerrit.osmocom.org/#/c/10250/2/src/osmo-euse-demo.c@182
PS2, Line 182: char *server_host = "127.0.0.1";
let's make at least the host name configurable
--
To view, visit https://gerrit.osmocom.org/10250
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3fb8554ca329cb609c591058254117006f665e73
Gerrit-Change-Number: 10250
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Mon, 30 Jul 2018 14:51:34 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180730/4e7125dc/attachment.htm>