This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgHello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/10172 to look at the new patch set (#2). Change subject: mgcp_network: translate payload type numbers in RTP packets ...................................................................... mgcp_network: translate payload type numbers in RTP packets Since no transcoding is in place osmo-mgw forwards the incoming rtp packets as they are (there may be minor modifications of the header) from an ingress connection to an egress connection. This works without problems as long as both connections use the same payload type. For IANA defined fixed payload type numbers this is usually the case, but for dynemic payload type numbers both ends may set up the same codecs but with different payload type numbers. When different payload type numbers are set up, and the packet is passed through without modification, it will have the wrong payload type when it is sent. The receiving end may then toss the packet since it expects packets with the payload type it has configured. The machanism, which is introduced with this patch looks up actual codec inside the struct data of the ingress connection and then looks for the matching codec in the struct data of the egress connection. When it finds the codec there it looks up the payload type of this codec. The header of the RTP packet is then patched with the correct payoad type. - Add function mgcp_codec_pt_translate() to look up the payload type - Add unit-test for function mgcp_codec_pt_translate() - Add payload type translation to mgcp_network.c Change-Id: I3a874e59fa07bcc2a67c376cafa197360036f539 Related: OS#2728 Related: OS#3384 --- M include/osmocom/mgcp/mgcp_codec.h M src/libosmo-mgcp/mgcp_codec.c M src/libosmo-mgcp/mgcp_network.c M tests/mgcp/mgcp_test.c 4 files changed, 204 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/72/10172/2 -- To view, visit https://gerrit.osmocom.org/10172 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3a874e59fa07bcc2a67c376cafa197360036f539 Gerrit-Change-Number: 10172 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180727/c672cfd4/attachment.htm>