This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10180 ) Change subject: cosmetic: typos in log and comment ...................................................................... cosmetic: typos in log and comment Change-Id: I2416d9a45e88f4317aa8e6644f5581a6f4f119c8 --- M src/libmsc/msc_mgcp.c 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified Harald Welte: Looks good to me, approved diff --git a/src/libmsc/msc_mgcp.c b/src/libmsc/msc_mgcp.c index e261e7a..f5bdeb7 100644 --- a/src/libmsc/msc_mgcp.c +++ b/src/libmsc/msc_mgcp.c @@ -315,8 +315,8 @@ } /* HACK: We put the connection in loopback mode at the beginnig to - * trick the NodeB into doing the IuUP negotiation with itsself. - * this is a hack we need because osmo-mgw does not support IuUP yet */ + * trick the hNodeB into doing the IuUP negotiation with itself. + * This is a hack we need because osmo-mgw does not support IuUP yet, see OS#2459. */ #ifdef BUILD_IU if (conn->via_ran == RAN_UTRAN_IU) mgcp_msg.conn_mode = MGCP_CONN_LOOPBACK; @@ -1044,19 +1044,19 @@ OSMO_ASSERT(conn); if (port == 0) { - LOGP(DMGCP, LOGL_ERROR, "(subscriber:%s) invalid remote call leg port, assignmnet completion failed\n", + LOGP(DMGCP, LOGL_ERROR, "(subscriber:%s) invalid remote call leg port, assignment completion failed\n", vlr_subscr_name(conn->vsub)); return -EINVAL; } if (!addr || strlen(addr) <= 0) { - LOGP(DMGCP, LOGL_ERROR, "(subscriber:%s) missing remote call leg address, assignmnet completion failed\n", + LOGP(DMGCP, LOGL_ERROR, "(subscriber:%s) missing remote call leg address, assignment completion failed\n", vlr_subscr_name(conn->vsub)); return -EINVAL; } mgcp_ctx = conn->rtp.mgcp_ctx; if (!mgcp_ctx) { - LOGP(DMGCP, LOGL_ERROR, "(subscriber:%s) invalid mgcp context, assignmnet completion failed.\n", + LOGP(DMGCP, LOGL_ERROR, "(subscriber:%s) invalid mgcp context, assignment completion failed.\n", vlr_subscr_name(conn->vsub)); return -EINVAL; } @@ -1066,7 +1066,7 @@ conn->rtp.remote_port_ran = port; osmo_strlcpy(conn->rtp.remote_addr_ran, addr, sizeof(conn->rtp.remote_addr_ran)); - LOGP(DMGCP, LOGL_DEBUG, "(subscriber:%s) assignmnet completed, rtp %s:%d.\n", + LOGP(DMGCP, LOGL_DEBUG, "(subscriber:%s) assignment completed, rtp %s:%d.\n", vlr_subscr_name(conn->vsub), conn->rtp.remote_addr_ran, port); /* Note: We only dispatch the event if we are really waiting for the -- To view, visit https://gerrit.osmocom.org/10180 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2416d9a45e88f4317aa8e6644f5581a6f4f119c8 Gerrit-Change-Number: 10180 Gerrit-PatchSet: 2 Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180727/96316a76/attachment.htm>