Change in osmo-msc[master]: Iu MGCP: no need to loopback on the cn side

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Jul 27 07:38:54 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10179 )

Change subject: Iu MGCP: no need to loopback on the cn side
......................................................................

Iu MGCP: no need to loopback on the cn side

Change-Id: I501a7846c76dd703beb3991362b1ccbd62dfd155
---
M src/libmsc/msc_mgcp.c
1 file changed, 0 insertions(+), 8 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/libmsc/msc_mgcp.c b/src/libmsc/msc_mgcp.c
index c77e389..e261e7a 100644
--- a/src/libmsc/msc_mgcp.c
+++ b/src/libmsc/msc_mgcp.c
@@ -437,14 +437,6 @@
 		return;
 	}
 
-	/* HACK: We put the connection in loopback mode at the beginnig to
-	 * trick the NodeB into doing the IuUP negotiation with itsself.
-	 * this is a hack we need because osmo-mgw does not support IuUP yet */
-#ifdef BUILD_IU
-	if (conn->via_ran == RAN_UTRAN_IU)
-		mgcp_msg.conn_mode = MGCP_CONN_LOOPBACK;
-#endif
-
 	msg = mgcp_msg_gen(mgcp, &mgcp_msg);
 	OSMO_ASSERT(msg);
 

-- 
To view, visit https://gerrit.osmocom.org/10179
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I501a7846c76dd703beb3991362b1ccbd62dfd155
Gerrit-Change-Number: 10179
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180727/697f0c82/attachment.htm>


More information about the gerrit-log mailing list